[Mesa-dev] [PATCH 2/2] intel/compiler: Use null destination register for memory fence messages

[Kenneth Graunke]

On Wednesday, February 7, 2018 1:21:53 PM PST Anuj Phogat wrote:
> On Wed, Feb 7, 2018 at 12:24 PM, Francisco Jerez wrote:
> > Anuj Phogat writes:
> > > On Wed, Feb 7, 2018 at 11:55 AM, Francisco Jerez wrote:
> > > > You can also just drop the patch, unless you want to change the
> > > > front-end in addition to stop allocating a destination for memory fences
> > > > on HSW-SKL in order to save a small amount of register pressure?
> > > >
> > > It also fixes a fulsim error other than reducing register pressure.
> >
> > On what platform?
>
> I noticed this on Icelake. But, I'm sure it exists on CNL as well.

But in patch 1, you always set commit enable on Gen10+.  So you wouldn't
hit the "no commit" case that wants a null destination.

I'm guessing you saw that before you wrote patch 1 (and reordered them)?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180207/c06c11e7/attachment.sig>