[Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

[Jason Ekstrand]

On Wed, Feb 14, 2018 at 9:42 AM, Ville Syrjälä <
ville.syrjala at linux.intel.com> wrote:

> On Wed, Feb 14, 2018 at 04:43:15PM +0000, Daniel Stone wrote:
> > On 14 February 2018 at 16:27, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone <daniel at fooishbar.org>
> wrote:
> > >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone <
> daniel at fooishbar.org> wrote:
> > >> >> For actual scanout, the kernel very specifically demands that if
> the
> > >> >> BO is X-tiled, then set_tiling be called with TILING_X. This
> applies
> > >> >> even if we explicitly allocate with MOD_X_TILED and pass that in
> via
> > >> >> drmModeAddFB2WithModifiers: there is an explicit check for
> > >> >> !!(bo_tiling == TILING_X) == !!(modifier == MOD_X_TILED).
> > >>
> > >> You missed this bit. Suggested fixup: https://hastebin.com/xikopobiza
> > >
> > > I was really hoping I'd read wrong.  I'm going with "that's a kernel
> bug".
>
> Old kernels required TILING_X with MOD_X.


How many kernels is that?


> I changed that at some
> point to allow TILING_NONE with any modifier, but otherwise we
> require the BO tiling to match the modifier. Ie. you still can't
> mix TILING_Y + MOD_X for example.
>

Right.  That's perfectly reasonable.  It should be either TILING_NONE or
match.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180214/3155348b/attachment-0001.html>