[Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

[Anuj Phogat]

On Wed, Feb 21, 2018 at 11:04 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Wed, Feb 21, 2018 at 10:37 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli
>> <rafael.antognolli at intel.com> wrote:
>>> My understanding is that this commit is enough to make the driver try to
>>> initialize, at least for i965. If that's the case, how about we add
>>> something like what was removed by commit
>>> bf1577fe0972ae910c071743dc89d261a46c2926 for CNL?
>>>
>>> It could be either in this commit, or in a commit that precedes this
>>> one. Anv has an extra check for gen <= 10, so we don't need to worry
>>> there yet.
>> Yes, It'll be great to add a similar patch before this one. Also, I
>> think this patch should be the last patch in this series. Otherwise we'll
>> have a commit with ICL PCI IDs but missing compiler changes. Almost
>> nothing will work without the compiler patches.
>
> Good point. The reason I moved it here was because a few of my patches
> add new fields to GEN11_FEATURES. How about I split the patch in two:
> one that modifies gen_device_info.c and another for later that
> actually adds the PCI IDs?
Sounds good to me.