[Mesa-dev] [PATCH] anv: Add missing unlock in anv_scratch_pool_alloc

Lionel Landwerlin lionel.g.landwerlin at intel.com
Thu Jan 4 11:49:24 UTC 2018


Thanks Alex,

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 04/01/18 11:33, Alex Smith wrote:
> Fixes hangs seen due to the lock not being released here.
>
> Signed-off-by: Alex Smith <asmith at feralinteractive.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>   src/intel/vulkan/anv_allocator.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c
> index 33bd3c68c5..fe14d6cfab 100644
> --- a/src/intel/vulkan/anv_allocator.c
> +++ b/src/intel/vulkan/anv_allocator.c
> @@ -1088,8 +1088,10 @@ anv_scratch_pool_alloc(struct anv_device *device, struct anv_scratch_pool *pool,
>      pthread_mutex_lock(&device->mutex);
>   
>      __sync_synchronize();
> -   if (bo->exists)
> +   if (bo->exists) {
> +      pthread_mutex_unlock(&device->mutex);
>         return &bo->bo;
> +   }
>   
>      const struct anv_physical_device *physical_device =
>         &device->instance->physicalDevice;




More information about the mesa-dev mailing list