[Mesa-dev] [PATCH] anv: Add missing unlock in anv_scratch_pool_alloc

[Jason Ekstrand]

Wow, I have no idea how that hasn't been caught yet.  Rb


On January 4, 2018 05:33:53 Alex Smith <asmith at feralinteractive.com> wrote:

> Fixes hangs seen due to the lock not being released here.
>
> Signed-off-by: Alex Smith <asmith at feralinteractive.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/intel/vulkan/anv_allocator.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_allocator.c 
> b/src/intel/vulkan/anv_allocator.c
> index 33bd3c68c5..fe14d6cfab 100644
> --- a/src/intel/vulkan/anv_allocator.c
> +++ b/src/intel/vulkan/anv_allocator.c
> @@ -1088,8 +1088,10 @@ anv_scratch_pool_alloc(struct anv_device *device, 
> struct anv_scratch_pool *pool,
>     pthread_mutex_lock(&device->mutex);
>
>     __sync_synchronize();
> -   if (bo->exists)
> +   if (bo->exists) {
> +      pthread_mutex_unlock(&device->mutex);
>        return &bo->bo;
> +   }
>
>     const struct anv_physical_device *physical_device =
>        &device->instance->physicalDevice;
> --
> 2.13.6
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev