[Mesa-dev] [PATCH] mesa: Tidy up the 4.6 section of GL4x.xml

[Ian Romanick]

Thanks!

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 01/05/2018 02:48 AM, Neil Roberts wrote:
> The enums are moved to the top and indented like the rest of the file.
> Comments are added to split up the function aliases by corresponding
> extension. This should make no functional difference.
> ---
> 
> This was requested by Ian Romanick as part of the review of the patch
> to add the aliases for GL_ARB_indirect_parameters.
> 
>  src/mapi/glapi/gen/GL4x.xml | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/src/mapi/glapi/gen/GL4x.xml b/src/mapi/glapi/gen/GL4x.xml
> index 4b2703c..cd2e3b8 100644
> --- a/src/mapi/glapi/gen/GL4x.xml
> +++ b/src/mapi/glapi/gen/GL4x.xml
> @@ -67,15 +67,21 @@
>  </category>
>  
>  <category name="4.6">
> +  <enum name="PARAMETER_BUFFER"                          value="0x80EE"/>
> +  <enum name="PARAMETER_BUFFER_BINDING"                  value="0x80EF"/>
> +  <enum name="POLYGON_OFFSET_CLAMP"                      value="0x8E1B"/>
> +  <enum name="SHADER_BINARY_FORMAT_SPIR_V"               value="0x9551"/>
> +  <enum name="SPIR_V_BINARY"                             value="0x9552"/>
> +
> +  <!-- This function aliases one from GL_EXT_polygon_offset_clamp -->
> +
>    <function name="PolygonOffsetClamp" alias="PolygonOffsetClampEXT">
>      <param name="factor" type="GLfloat"/>
>      <param name="units" type="GLfloat"/>
>      <param name="clamp" type="GLfloat"/>
>    </function>
> -  <enum name="POLYGON_OFFSET_CLAMP" value="0x8E1B"/>
>  
> -  <enum name="SHADER_BINARY_FORMAT_SPIR_V" value="0x9551"/>
> -  <enum name="SPIR_V_BINARY" value="0x9552"/>
> +  <!-- This function aliases one from GL_ARB_gl_spirv -->
>  
>    <function name="SpecializeShader" alias="SpecializeShaderARB">
>      <param name="shader" type="GLuint"/>
> @@ -85,8 +91,7 @@
>      <param name="pConstantValue" type="const GLuint *"/>
>    </function>
>  
> -  <enum name="PARAMETER_BUFFER" value="0x80EE"/>
> -  <enum name="PARAMETER_BUFFER_BINDING" value="0x80EF"/>
> +  <!-- These functions alias ones from GL_ARB_indirect_parameters -->
>  
>    <function name="MultiDrawArraysIndirectCount"
>              alias="MultiDrawArraysIndirectCountARB">
>