[Mesa-dev] [PATCH] anv: fix maxDescriptorSet* limits

[Jason Ekstrand]

On Wed, Jan 10, 2018 at 1:35 AM, Samuel Iglesias Gonsálvez <
siglesias at igalia.com> wrote:

> "The maxDescriptorSet* limit is n times the corresponding
> maxPerStageDescriptor* limit, where n is the number of shader stages
> supported by the VkPhysicalDevice. If all shader stages are supported,
> n = 6 (vertex, tessellation control, tessellation evaluation,
> geometry, fragment, compute)."
>
> Fixes:
>
> dEQP-VK.api.info.device.properties
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> ---
>
> Fixes CL#2078.
>
> Jason, I don't now if is there any HW limitation for these.
>

Nope, this should be fine.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


>  src/intel/vulkan/anv_device.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 680f5a752d6..90fdda66c5b 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -797,13 +797,13 @@ void anv_GetPhysicalDeviceProperties(
>        .maxPerStageDescriptorStorageImages       = 64,
>        .maxPerStageDescriptorInputAttachments    = 64,
>        .maxPerStageResources                     = 250,
> -      .maxDescriptorSetSamplers                 = 256,
> -      .maxDescriptorSetUniformBuffers           = 256,
> +      .maxDescriptorSetSamplers                 = 6 * max_samplers, /*
> number of stages * maxPerStageDescriptorSamplers */
> +      .maxDescriptorSetUniformBuffers           = 6 * 64,           /*
> number of stages * maxPerStageDescriptorUniformBuffers */
>        .maxDescriptorSetUniformBuffersDynamic    = MAX_DYNAMIC_BUFFERS /
> 2,
> -      .maxDescriptorSetStorageBuffers           = 256,
> +      .maxDescriptorSetStorageBuffers           = 6 * 64,           /*
> number of stages * maxPerStageDescriptorStorageBuffers */
>        .maxDescriptorSetStorageBuffersDynamic    = MAX_DYNAMIC_BUFFERS /
> 2,
> -      .maxDescriptorSetSampledImages            = 256,
> -      .maxDescriptorSetStorageImages            = 256,
> +      .maxDescriptorSetSampledImages            = 6 * max_samplers, /*
> number of stages * maxPerStageDescriptorSampledImages */
> +      .maxDescriptorSetStorageImages            = 6 * 64,           /*
> number of stages * maxPerStageDescriptorStorageImages */
>        .maxDescriptorSetInputAttachments         = 256,
>        .maxVertexInputAttributes                 = MAX_VBS,
>        .maxVertexInputBindings                   = MAX_VBS,
> --
> 2.14.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180110/cdfe75cd/attachment-0001.html>