[Mesa-dev] [PATCH 01/11] vbo: lift common code out of switch cases

Brian Paul brianp at vmware.com
Wed Jan 17 17:31:49 UTC 2018


On 01/17/2018 07:20 AM, Emil Velikov wrote:
> On 17 January 2018 at 05:17, Brian Paul <brianp at vmware.com> wrote:
>> Both switch cases began with the same code.
> Might even go a step further refactoring the common bits (say ~90%) of
> the two functions into a helper.
> One step at a time though - patch is a good start.

Yeah, there's tons of similar code between the immediate mode and dlist 
drawing code.  I'm not sure I'll tackle that.  I'm just making 
clean-ups/fixes as I work on some optimizations (not ready for quite 
review yet).

> 
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks.  I added the STATIC_ASSERT you suggested too.

-Brian




More information about the mesa-dev mailing list