[Mesa-dev] [PATCH] nir: mark unused space in packed_tex_data

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Fri, Jan 26, 2018 at 1:30 AM, Tapani Pälli <tapani.palli at intel.com>
wrote:

> This change cleans following scary warnings in valgrind output
> when disk cache is being written:
>
>    ==6532== Uninitialised byte(s) found during client check request
>    ==6532==    at 0x14423FAD: blob_write_bytes (blob.c:152)
>    ==6532==    by 0x144240FB: blob_write_uint32 (blob.c:194)
>    ==6532==    by 0x144001A5: write_tex (nir_serialize.c:613)
>
> and later (loads of):
>
>    ==6532== Use of uninitialised value of size 8
>    ==6532==    at 0x62FCD9E: crc32_z (in /usr/lib64/libz.so.1.2.11)
>    ==6532==    by 0x13F65014: util_hash_crc32 (crc32.c:127)
>    ==6532==    by 0x13F5DABA: cache_put (disk_cache.c:947)
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  src/compiler/nir/nir_serialize.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/compiler/nir/nir_serialize.c b/src/compiler/nir/nir_
> serialize.c
> index 54a00c81d6..9fe46a675f 100644
> --- a/src/compiler/nir/nir_serialize.c
> +++ b/src/compiler/nir/nir_serialize.c
> @@ -585,6 +585,7 @@ union packed_tex_data {
>        unsigned component:2;
>        unsigned has_texture_deref:1;
>        unsigned has_sampler_deref:1;
> +      unsigned unused:10; /* Mark unused for valgrind. */
>     } u;
>  };
>
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180126/8616911c/attachment.html>