[Mesa-dev] [PATCH] nir: mark unused space in packed_tex_data

Emil Velikov emil.l.velikov at gmail.com
Fri Jan 26 13:06:02 UTC 2018


On 26 January 2018 at 09:30, Tapani Pälli <tapani.palli at intel.com> wrote:
> This change cleans following scary warnings in valgrind output
> when disk cache is being written:
>
>    ==6532== Uninitialised byte(s) found during client check request
>    ==6532==    at 0x14423FAD: blob_write_bytes (blob.c:152)
>    ==6532==    by 0x144240FB: blob_write_uint32 (blob.c:194)
>    ==6532==    by 0x144001A5: write_tex (nir_serialize.c:613)
>
> and later (loads of):
>
>    ==6532== Use of uninitialised value of size 8
>    ==6532==    at 0x62FCD9E: crc32_z (in /usr/lib64/libz.so.1.2.11)
>    ==6532==    by 0x13F65014: util_hash_crc32 (crc32.c:127)
>    ==6532==    by 0x13F5DABA: cache_put (disk_cache.c:947)
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---

Tapani,

I believe we want to have you valgrind inspired fixes for the stable branches.
Hence my fixes/stable suggestions ;-)

Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil


More information about the mesa-dev mailing list