[Mesa-dev] [PATCH shaderdb 1/2] run: fall back to v3.1 core ctx if v3.2 fails

[Matt Turner]

On Sat, Jan 27, 2018 at 4:08 PM, Rob Clark <robdclark at gmail.com> wrote:
> On Sat, Jan 27, 2018 at 7:02 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Sat, Jan 27, 2018 at 10:06 AM, Rob Clark <robdclark at gmail.com> wrote:
>>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>>> ---
>>>  run.c | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>
>>> diff --git a/run.c b/run.c
>>> index 69fe23d..20a0a6a 100644
>>> --- a/run.c
>>> +++ b/run.c
>>> @@ -520,6 +520,18 @@ main(int argc, char **argv)
>>>      };
>>>      EGLContext core_ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT,
>>>                                             attribs);
>>> +
>>> +    if (core_ctx == EGL_NO_CONTEXT) {
>>> +        static const EGLint attribs_31[] = {
>>> +            EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR,
>>> +            EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR,
>>
>> Profiles are only introduced in v3.2. I can't see how this can work.
>>
>
> entirely possible by accident.. not quite sure when shader-db started
> asking for 3.2 core profile, but that broke things for freedreno (and
> this patch "fixed" things)

Must have never worked. run.c created core profiles from its inception.