[Mesa-dev] [PATCH] i965: Fix BRW_NEW_NUM_SAMPLES to be in .brw, not .mesa

Jason Ekstrand jason at jlekstrand.net
Mon Jul 2 22:02:38 UTC 2018


Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Mon, Jul 2, 2018 at 2:19 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> This is the wrong kind of dirty bit.  Caught by GCC warnings, due to
> 64-bit values being truncated to 32 bits.
>
> Fixes: b95b0e2918c052068caeb4f6c2802ba89be043a3 (intel/anv,blorp,i965:
> Implement the SKL 16x MSAA SIMD32 workaround)
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index b279f01e1a1..7fe12887030 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -4073,13 +4073,13 @@ genX(upload_ps)(struct brw_context *brw)
>  static const struct brw_tracked_state genX(ps_state) = {
>     .dirty = {
>        .mesa  = _NEW_MULTISAMPLE |
> -               (GEN_GEN >= 9 ? BRW_NEW_NUM_SAMPLES : 0) |
>                 (GEN_GEN < 8 ? _NEW_BUFFERS |
>                                _NEW_COLOR
>                              : 0),
>        .brw   = BRW_NEW_BATCH |
>                 BRW_NEW_BLORP |
> -               BRW_NEW_FS_PROG_DATA,
> +               BRW_NEW_FS_PROG_DATA |
> +               (GEN_GEN >= 9 ? BRW_NEW_NUM_SAMPLES : 0),
>     },
>     .emit = genX(upload_ps),
>  };
> --
> 2.18.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180702/977403c2/attachment-0001.html>


More information about the mesa-dev mailing list