[Mesa-dev] [RFC 5/5] DEBUG

[Emil Velikov]

Hi Rob,

On 5 July 2018 at 11:07, Robert Foss <robert.foss at collabora.com> wrote:

> @@ -511,7 +515,7 @@ dri2_open_driver(_EGLDisplay *disp)
>     char path[PATH_MAX], *search_paths, *next, *end;
>     char *get_extensions_name;
>     const __DRIextension **(*get_extensions)(void);
> -
> +   ALOGE("%s() 1 driver_name=%s", __func__, dri2_dpy->driver_name);
Aside:
Personally, I try to use "before/after X". Otherwise I find myself
always bouncing back and forth, relate the 1, 1.1... with the actual
call chain.


> @@ -1367,10 +1379,6 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay *disp)
>     const char *err;
>     int ret;
>
> -   /* Not supported yet */
> -   if (disp->Options.ForceSoftware)
> -      return EGL_FALSE;
> -
Even with the issues you mentioned in the cover letter, this could be
fleshed out or even squashed with 3/5. Up-to you really.

-Emil