[Mesa-dev] [RFC 5/5] DEBUG

[Robert Foss]

Hey Emil,

On 05/07/18 15:13, Emil Velikov wrote:
> Hi Rob,
> 
> On 5 July 2018 at 11:07, Robert Foss <robert.foss at collabora.com> wrote:
> 
>> @@ -511,7 +515,7 @@ dri2_open_driver(_EGLDisplay *disp)
>>      char path[PATH_MAX], *search_paths, *next, *end;
>>      char *get_extensions_name;
>>      const __DRIextension **(*get_extensions)(void);
>> -
>> +   ALOGE("%s() 1 driver_name=%s", __func__, dri2_dpy->driver_name);
> Aside:
> Personally, I try to use "before/after X". Otherwise I find myself
> always bouncing back and forth, relate the 1, 1.1... with the actual
> call chain.

Hmmph, yeah. Maybe that is a more pleasant way of going about it.
I'll have to feel it out :)

> 
> 
>> @@ -1367,10 +1379,6 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay *disp)
>>      const char *err;
>>      int ret;
>>
>> -   /* Not supported yet */
>> -   if (disp->Options.ForceSoftware)
>> -      return EGL_FALSE;
>> -
> Even with the issues you mentioned in the cover letter, this could be
> fleshed out or even squashed with 3/5. Up-to you really.

This chunk shouldn't really be in this patch. I had some issues setting the 
Android property and while figuring out that the property wasn't propagated 
properly this chunk was removed.

The debug patch will be dropped in v1, so this will be removed.

> 
> -Emil
>