[Mesa-dev] [PATCH 2/3] mesa: verify MaxVertexAttribStride for GL 4.4

Erik Faye-Lund erik.faye-lund at collabora.com
Fri Jul 6 10:03:56 UTC 2018


The OpenGL 4.4 specification, table Table 23.55 ("Implementation
Dependent Values"), defines the minimum-maximum value for
MAX_VERTEX_ATTRIB_STRIDE to be 2048.

So we shouldn't enable OpenGL 4.4 on implementations where this isn't
the case. Let's add a check for this.

Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
---
 src/mesa/main/version.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index 2ba4c0b57f..0b0d5b79d6 100644
--- a/src/mesa/main/version.c
+++ b/src/mesa/main/version.c
@@ -369,6 +369,7 @@ compute_version(const struct gl_extensions *extensions,
                          extensions->ARB_texture_view);
    const bool ver_4_4 = (ver_4_3 &&
                          consts->GLSLVersion >= 440 &&
+                         consts->MaxVertexAttribStride >= 2048 &&
                          extensions->ARB_buffer_storage &&
                          extensions->ARB_clear_texture &&
                          extensions->ARB_enhanced_layouts &&
-- 
2.18.0.rc2



More information about the mesa-dev mailing list