[Mesa-dev] [PATCH 1/3] r600: report incorrect max-vertex-attrib for GL 4.4

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Fri, Jul 6, 2018 at 6:03 AM, Erik Faye-Lund
<erik.faye-lund at collabora.com> wrote:
> OpenGL 4.4 requires a max vertex attrib of 2048 or higher, but
> r600 only supports 2047. Technically, this makes it an GL4.3 GPU,
> but it's currently exposing GL4.4.
>
> To avoid regressing the GL version supported in the following
> patches, let's just lie and pretend like we support 2048. Any
> applications using 2048 are already broken anyway.
>
> Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
> ---
>  src/gallium/drivers/r600/r600_pipe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
> index bc5660d6d1..2518032145 100644
> --- a/src/gallium/drivers/r600/r600_pipe.c
> +++ b/src/gallium/drivers/r600/r600_pipe.c
> @@ -470,7 +470,8 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>                 return family >= CHIP_CEDAR ? 4 : 1;
>
>         case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:
> -               return 2047;
> +               /* Should be 2047, but 2048 is a requirement for GL 4.4 */
> +               return 2048;
>
>         /* Texturing. */
>         case PIPE_CAP_MAX_TEXTURE_2D_LEVELS:
> --
> 2.18.0.rc2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev