[Mesa-dev] [PATCH] intel/compiler: remove unused function

Lionel Landwerlin lionel.g.landwerlin at intel.com
Mon Jul 9 10:12:03 UTC 2018


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 09/07/18 10:49, Iago Toral Quiroga wrote:
> ---
>   src/intel/compiler/brw_fs.cpp | 27 ---------------------------
>   src/intel/compiler/brw_fs.h   |  4 ----
>   2 files changed, 31 deletions(-)
>
> diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
> index 38a8621f2c..99b21f6d89 100644
> --- a/src/intel/compiler/brw_fs.cpp
> +++ b/src/intel/compiler/brw_fs.cpp
> @@ -6444,33 +6444,6 @@ fs_visitor::dump_instruction(backend_instruction *be_inst, FILE *file)
>      fprintf(file, "\n");
>   }
>   
> -/**
> - * Possibly returns an instruction that set up @param reg.
> - *
> - * Sometimes we want to take the result of some expression/variable
> - * dereference tree and rewrite the instruction generating the result
> - * of the tree.  When processing the tree, we know that the
> - * instructions generated are all writing temporaries that are dead
> - * outside of this tree.  So, if we have some instructions that write
> - * a temporary, we're free to point that temp write somewhere else.
> - *
> - * Note that this doesn't guarantee that the instruction generated
> - * only reg -- it might be the size=4 destination of a texture instruction.
> - */
> -fs_inst *
> -fs_visitor::get_instruction_generating_reg(fs_inst *start,
> -					   fs_inst *end,
> -					   const fs_reg &reg)
> -{
> -   if (end == start ||
> -       end->is_partial_write() ||
> -       !reg.equals(end->dst)) {
> -      return NULL;
> -   } else {
> -      return end;
> -   }
> -}
> -
>   void
>   fs_visitor::setup_fs_payload_gen6()
>   {
> diff --git a/src/intel/compiler/brw_fs.h b/src/intel/compiler/brw_fs.h
> index 25c433e44f..c09f0ccdd3 100644
> --- a/src/intel/compiler/brw_fs.h
> +++ b/src/intel/compiler/brw_fs.h
> @@ -83,10 +83,6 @@ public:
>      void setup_uniform_clipplane_values();
>      void compute_clip_distance();
>   
> -   fs_inst *get_instruction_generating_reg(fs_inst *start,
> -					   fs_inst *end,
> -					   const fs_reg &reg);
> -
>      void VARYING_PULL_CONSTANT_LOAD(const brw::fs_builder &bld,
>                                      const fs_reg &dst,
>                                      const fs_reg &surf_index,




More information about the mesa-dev mailing list