[Mesa-dev] [PATCH] intel/fs: use uint type for per_slot_offset at GS

Samuel Iglesias Gonsálvez siglesias at igalia.com
Mon Jul 9 10:32:42 UTC 2018


Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>


On 12/06/18 18:51, Jose Maria Casanova Crespo wrote:
> This helps us to compact original instruction:
>
> mul(8)  g3<1>D  g6<8,8,1>UD  0x00000006UD { align1 1Q };
>
> So now we emit:
>
> mul(8)  g3<1>UD g6<8,8,1>UD  0x00000006UD { align1 1Q compacted };
> ---
>  src/intel/compiler/brw_fs_visitor.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/compiler/brw_fs_visitor.cpp b/src/intel/compiler/brw_fs_visitor.cpp
> index a24808eac69..7159d78a86d 100644
> --- a/src/intel/compiler/brw_fs_visitor.cpp
> +++ b/src/intel/compiler/brw_fs_visitor.cpp
> @@ -597,7 +597,7 @@ fs_visitor::emit_urb_writes(const fs_reg &gs_vertex_count)
>           per_slot_offsets = brw_imm_ud(output_vertex_size_owords *
>                                         gs_vertex_count.ud);
>        } else {
> -         per_slot_offsets = vgrf(glsl_type::int_type);
> +         per_slot_offsets = vgrf(glsl_type::uint_type);
>           bld.MUL(per_slot_offsets, gs_vertex_count,
>                   brw_imm_ud(output_vertex_size_owords));
>        }

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180709/954ea56a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180709/954ea56a/attachment.sig>


More information about the mesa-dev mailing list