[Mesa-dev] [PATCH] radv: print a big warning when RADV_TRACE_FILE is set

Samuel Pitoiset samuel.pitoiset at gmail.com
Fri Jul 20 16:47:03 UTC 2018


Users shouldn't use this debugging option except when we
ask them to do!

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_device.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 80ddb65480..7dc6508333 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1561,6 +1561,10 @@ VkResult radv_CreateDevice(
 		if (!radv_init_trace(device))
 			goto fail;
 
+		fprintf(stderr, "*****************************************************************************\n");
+		fprintf(stderr, "* WARNING: RADV_TRACE_FILE is costly and should only be used for debugging! *\n");
+		fprintf(stderr, "*****************************************************************************\n");
+
 		fprintf(stderr, "Trace file will be dumped to %s\n", filename);
 		radv_dump_enabled_options(device, stderr);
 	}
-- 
2.18.0



More information about the mesa-dev mailing list