[Mesa-dev] [PATCH] radv: print a big warning when RADV_TRACE_FILE is set

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

Thanks!

On Fri, Jul 20, 2018 at 6:47 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Users shouldn't use this debugging option except when we
> ask them to do!
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_device.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 80ddb65480..7dc6508333 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -1561,6 +1561,10 @@ VkResult radv_CreateDevice(
>                 if (!radv_init_trace(device))
>                         goto fail;
>
> +               fprintf(stderr, "*****************************************************************************\n");
> +               fprintf(stderr, "* WARNING: RADV_TRACE_FILE is costly and should only be used for debugging! *\n");
> +               fprintf(stderr, "*****************************************************************************\n");
> +
>                 fprintf(stderr, "Trace file will be dumped to %s\n", filename);
>                 radv_dump_enabled_options(device, stderr);
>         }
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev