[Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

Daniel Stone daniel at fooishbar.org
Thu Jul 26 08:15:27 UTC 2018

On Thu, 26 Jul 2018 at 08:46, Olivier Fourdan <ofourdan at redhat.com> wrote:
> get_supported_modifiers() and pixmap_from_buffers() requests both
> expect a window as drawable, passing a pixmap will fail as the Xserver
> will fail to match the given drawable to a window.
> That leads to dri3_alloc_render_buffer() to return NULL and breaks
> rendering when using GLX_DOUBLEBUFFER on pixmaps.
> Query the root window of the pixmap on first init, and use the root
> window instead of the pixmap drawable for get_supported_modifiers()
> and pixmap_from_buffers().

Looks good to me, thanks Olivier!

Reviewed-by: Daniel Stone <daniels at collabora.com>


More information about the mesa-dev mailing list