[Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

Eric Anholt eric at anholt.net
Thu Jul 26 17:45:30 UTC 2018

Olivier Fourdan <ofourdan at redhat.com> writes:

> get_supported_modifiers() and pixmap_from_buffers() requests both
> expect a window as drawable, passing a pixmap will fail as the Xserver
> will fail to match the given drawable to a window.
> That leads to dri3_alloc_render_buffer() to return NULL and breaks
> rendering when using GLX_DOUBLEBUFFER on pixmaps.
> Query the root window of the pixmap on first init, and use the root
> window instead of the pixmap drawable for get_supported_modifiers()
> and pixmap_from_buffers().
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107117
> Fixes: 069fdd5 ("egl/x11: Support DRI3 v1.1")
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>

Looks great!

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180726/2095c73a/attachment.sig>

More information about the mesa-dev mailing list