[Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

[Eric Engestrom]

On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote:
> If you could deal with Daniel's feedback and v3 just this patch sooner
> rather than later, that would be good.  I'd like to merge it before we
> switch to gitlab so we can start using gitlab CI artifacts for the website
> right away.  That way, it'll be ready for when the rest of the series lands.

It's unnecessary, but it doesn't hurt; leaving it in is fine.
You can land it now if you want, with my R-b as mentioned in v1 :)

While at it, `mkdir + cp -r docs/*` is also unnecessary, `cp -r docs public`
does the same thing.

> 
> On Thu, May 31, 2018 at 12:52 AM, Daniel Stone <daniel at fooishbar.org> wrote:
> 
> > Hi Laura,
> >
> > On 30 May 2018 at 23:53, Laura Ekstrand <laura at jlekstrand.net> wrote:
> > > @@ -0,0 +1,9 @@
> > > +pages:
> > > +   stage: deploy
> > > +   script:
> > > +   - mkdir .public
> > > +   - cp -r docs/* .public
> > > +   - mv .public public
> >
> > You should be able to just write into the 'public' folder directly.
> >
> > It seems like creating a new directory and then moving it is an
> > attempt to be atomic, which is absolutely the right thing to do! But
> > the Pages deploy is separate: the build starts from a completely clean
> > slate, and does not overwrite the live website being served by Pages.
> > It's only once the build has finished and the artifacts captured that
> > they're later moved in-place to serve Pages.
> >
> > Cheers,
> > Daniel
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >