[Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

[Juan A. Suarez Romero]

On Fri, 2018-06-01 at 10:57 +0100, Eric Engestrom wrote:
> On Friday, 2018-06-01 09:43:48 +0200, Juan A. Suarez Romero wrote:
> > On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote:
> > > Hi Laura,
> > > 
> > > On 30 May 2018 at 23:53, Laura Ekstrand <laura at jlekstrand.net> wrote:
> > > > @@ -0,0 +1,9 @@
> > > > +pages:
> > > > +   stage: deploy
> > > > +   script:
> > > > +   - mkdir .public
> > > > +   - cp -r docs/* .public
> > > > +   - mv .public public
> > > 
> > > You should be able to just write into the 'public' folder directly.
> > > 
> > > It seems like creating a new directory and then moving it is an
> > > attempt to be atomic, which is absolutely the right thing to do! But
> > > the Pages deploy is separate: the build starts from a completely clean
> > > slate, and does not overwrite the live website being served by Pages.
> > > It's only once the build has finished and the artifacts captured that
> > > they're later moved in-place to serve Pages.
> > > 
> > 
> > On top of Daniel suggestion, I would also restrict this job to master job
> > ("only: master"). This way, the pages are not re-deploying wrongly when someone
> > pushes to a different branch (like an stable branch).
> 
> Would it? I assume the httpd configuration points to a specific folder
> which happens to be the one the master branch of the selected repo
> (ldeks's mesa for now) deploys its artifacts to.
> 
> Making it `only: master` means that forks or branches or MR don't get
> built, which I think would be a loss; everyone would have to build
> locally to check the results, which would be especially annoying once
> we'd start using MRs, as it would make reviewing them quite a hassle.
> 

I was meaning only for the deploy job; for building the documentation, I agree
it is good to happen in any branch.


	J.A.


> > 
> > 
> > 	J.A.
> > 
> > 
> > > Cheers,
> > > Daniel
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
>