[Mesa-dev] [Bug 106594] [regression, apitrace, bisected] Prison Architect rendered unplayable by multicoloured flickering triangles and overlayed triangles when performing certain actions

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jun 5 05:51:29 UTC 2018


Kai <kai at dev.carbon-project.org> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Kai <kai at dev.carbon-project.org> ---
Fixed by the following commit on master:
> commit 1ac4439d6278e6c5f9da5499bbc50362f0c6759b
> Author: Mathias Fröhlich <mathias.froehlich at web.de>
> Date:   Fri Jun 1 19:10:08 2018 +0200
>     mesa: Make sure that imm draws are flushed before other draws execute.
>     The recent patch
>         mesa: Remove FLUSH_VERTICES from VAO state changes.
>         Pending draw calls on immediate mode or display list calls do
>         not depend on changes of the VAO state. So, remove calls to
>         FLUSH_VERTICES and flag _NEW_ARRAY as appropriate.
>     uncovered a problem that non immediate mode draw calls do only
>     flush outstanding immediate mode draws if FLUSH_UPDATE_CURRENT
>     is set in ctx->Driver.NeedFlush.
>     In that case, due to the sequence of _mesa_set_draw_vao commands
>     we could end up with the VAO from the FLUSH_VERTICES call set
>     into gl_context::Array._DrawVAO when the array draw is executed.
>     So the change pulls FLUSH_CURRENT out of _mesa_validate_* calls
>     into the array draw calls being validated.
>     The change introduces a new macro FLUSH_FOR_DRAW beside FLUSH_VERTICES
>     and FLUSH_CURRENT that flushes on changed current attributes as well
>     as on outstanding immediate mode draw calls. Use FLUSH_FOR_DRAW
>     in the non immediate mode draw code paths.
>     Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>     Tested-by: Kai Wasserbäch <kai at dev.carbon-project.org>
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106594
>     Signed-off-by: Mathias Fröhlich <Mathias.Froehlich at web.de>

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180605/92cf4a22/attachment-0001.html>

More information about the mesa-dev mailing list