[Mesa-dev] [Bug 106774] GLSL IR copy propagates loads of SSBOs

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jun 7 16:33:36 UTC 2018


--- Comment #15 from Jason Ekstrand <jason at jlekstrand.net> ---
(In reply to Michel Dänzer from comment #10)
> (In reply to Jason Ekstrand from comment #9)
> > > > I'm not sure if you looked at it, but it is a piglit shader_runner test. 
> > > > The current failure mode is many (recoverable) GPU hangs.
> > 
> > I figured.  What other kind of simple shader test is there?  That was more
> > of a "Once you fix it, please commit to piglit".
> Please don't add piglit tests which are expected to hang the GPU, or at
> least don't set them up to be run by default. Not all drivers can reliably
> recover from GPU hangs.

The intention is not to add a test that hangs.  The two required fixes are to
the test and GLSL IR.  Once those are made, it shouldn't hang for anyone.

As far as general policy goes, no we don't want to have GPU hangs.  Maybe we
could even go so far to say that if you have a test which has a high
probability of hanging the GPU, it shouldn't be added to the test list by
default.  However there are many kinds of tests which might hang the GPU if the
driver has a bug as no fault of the test.  As someone who works on a very hangy
GPU, I'm keenly aware of this. :-)  That doesn't mean we shouldn't land those
tests; it means we should fix those drivers.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180607/54968bcc/attachment.html>

More information about the mesa-dev mailing list