[Mesa-dev] [PATCH 04/13] i965/draw: Fix adding the stencil bo to the depth cache

Nanley Chery nanleychery at gmail.com
Tue Jun 12 19:21:56 UTC 2018


Fix the case where only stencil writes are enabled on a depth stencil
texture. Found by inspection.

---

I'm looking into writing a test for this.

 src/mesa/drivers/dri/i965/brw_draw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index 271456e0f7d..71461d7b0a7 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -623,10 +623,10 @@ brw_postdraw_set_buffers_need_resolve(struct brw_context *brw)
    }
 
    if (stencil_irb && brw->stencil_write_enabled) {
-      brw_depth_cache_add_bo(brw, stencil_irb->mt->bo);
       struct intel_mipmap_tree *stencil_mt =
          stencil_irb->mt->stencil_mt != NULL ?
          stencil_irb->mt->stencil_mt : stencil_irb->mt;
+      brw_depth_cache_add_bo(brw, stencil_mt->bo);
       intel_miptree_finish_write(brw, stencil_mt, stencil_irb->mt_level,
                                  stencil_irb->mt_layer,
                                  stencil_irb->layer_count, ISL_AUX_USAGE_NONE);
-- 
2.17.0



More information about the mesa-dev mailing list