[Mesa-dev] [PATCH] virgl: add ARB_tessellation_shader support.

[Dave Airlie]

On 12 June 2018 at 23:25, Elie Tournier <tournier.elie at gmail.com> wrote:
> On Fri, Jun 08, 2018 at 03:15:36PM +1000, Dave Airlie wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> This should add all the pieces to enable tess shaders on virgl.
>
> Hi
>
> I think that we also need to add the following code:
>
> --- a/src/gallium/drivers/virgl/virgl_winsys.h
> +++ b/src/gallium/drivers/virgl/virgl_winsys.h
> @@ -127,7 +127,7 @@ static inline void virgl_ws_fill_new_caps_defaults(struct virgl_drm_caps *caps)
>     caps->caps.v2.max_geom_total_output_components = 1024;
>     caps->caps.v2.max_vertex_outputs = 32;
>     caps->caps.v2.max_vertex_attribs = 16;
> -   caps->caps.v2.max_shader_patch_varyings = 0;
> +   caps->caps.v2.max_shader_patch_varyings = 30;
>     caps->caps.v2.min_texel_offset = -8;
>     caps->caps.v2.max_texel_offset = 7;
>     caps->caps.v2.min_texture_gather_offset = -8;

Okay I see the problem, if you don't have a qemu/kernel that passes v2
you can see
tess enabled but this var is 0 and messes up the tests. I've been
testing with v2 caps.

I'll incorporate this fix.

Dave.