[Mesa-dev] [PATCH 14/14] intel/compiler: shuffle_64bit_data_for_32bit_write is not used anymore

[Jason Ekstrand]

12 and 14 are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Thanks for working on this!  This is very nice clean-up.

--Jason


On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo <
jmcasanova at igalia.com> wrote:

> ---
>  src/intel/compiler/brw_fs.h       |  4 ----
>  src/intel/compiler/brw_fs_nir.cpp | 32 -------------------------------
>  2 files changed, 36 deletions(-)
>
> diff --git a/src/intel/compiler/brw_fs.h b/src/intel/compiler/brw_fs.h
> index 1f86f17ccbb..17b1368d522 100644
> --- a/src/intel/compiler/brw_fs.h
> +++ b/src/intel/compiler/brw_fs.h
> @@ -499,10 +499,6 @@ private:
>     void *mem_ctx;
>  };
>
> -fs_reg shuffle_64bit_data_for_32bit_write(const brw::fs_builder &bld,
> -                                          const fs_reg &src,
> -                                          uint32_t components);
> -
>  void shuffle_from_32bit_read(const brw::fs_builder &bld,
>                               const fs_reg &dst,
>                               const fs_reg &src,
> diff --git a/src/intel/compiler/brw_fs_nir.cpp
> b/src/intel/compiler/brw_fs_nir.cpp
> index 833fad4247a..f68fe5f1d1a 100644
> --- a/src/intel/compiler/brw_fs_nir.cpp
> +++ b/src/intel/compiler/brw_fs_nir.cpp
> @@ -5187,38 +5187,6 @@ fs_visitor::nir_emit_jump(const fs_builder &bld,
> nir_jump_instr *instr)
>     }
>  }
>
> -/**
> - * This helper does the inverse operation of
> - * SHUFFLE_32BIT_LOAD_RESULT_TO_64BIT_DATA.
> - *
> - * We need to do this when we are going to use untyped write messsages
> that
> - * operate with 32-bit components in order to arrange our 64-bit data to
> be
> - * in the expected layout.
> - *
> - * Notice that callers of this function, unlike in the case of the inverse
> - * operation, would typically need to call this with dst and src being
> - * different registers, since they would otherwise corrupt the original
> - * 64-bit data they are about to write. Because of this the function
> checks
> - * that the src and dst regions involved in the operation do not overlap.
> - */
> -fs_reg
> -shuffle_64bit_data_for_32bit_write(const fs_builder &bld,
> -                                   const fs_reg &src,
> -                                   uint32_t components)
> -{
> -   assert(type_sz(src.type) == 8);
> -
> -   fs_reg dst = bld.vgrf(BRW_REGISTER_TYPE_D, 2 * components);
> -
> -   for (unsigned i = 0; i < components; i++) {
> -      const fs_reg component_i = offset(src, bld, i);
> -      bld.MOV(offset(dst, bld, 2 * i), subscript(component_i, dst.type,
> 0));
> -      bld.MOV(offset(dst, bld, 2 * i + 1), subscript(component_i,
> dst.type, 1));
> -   }
> -
> -   return dst;
> -}
> -
>  /*
>   * This helper takes a source register and un/shuffles it into the
> destination
>   * register.
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180613/36630e6f/attachment.html>