[Mesa-dev] [PATCH] anv: reduce maxFragmentInputComponents

[Samuel Iglesias Gonsálvez]

This patch is still unreviewed.

Sam


On 29/05/18 09:07, Samuel Iglesias Gonsálvez wrote:
> If the application asks for the maximum number of fragment input
> components (128), use all of them plus some builtins that are
> passed in the VUE, then we exceed the maximum number of used VUE
> slots (32) and we break one assert that checks this limit.
>
> Also, with separate shader objects, we add CLIP_DIST0, CLIP_DIST1
> builtins in brw_compute_vue_map() because we don't know if
> gl_ClipDistance is going to be read/write by an adjacent stage.
>
> Fixes VK-GL-CTS CL#2569.
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> ---
>  src/intel/vulkan/anv_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 374fc16c4c9..87c0d0cb4a6 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -898,7 +898,7 @@ void anv_GetPhysicalDeviceProperties(
>        .maxGeometryOutputComponents              = 128,
>        .maxGeometryOutputVertices                = 256,
>        .maxGeometryTotalOutputComponents         = 1024,
> -      .maxFragmentInputComponents               = 128,
> +      .maxFragmentInputComponents               = 112, /* 128 components - (POS, PSIZ, CLIP_DIST0, CLIP_DIST1) */
>        .maxFragmentOutputAttachments             = 8,
>        .maxFragmentDualSrcAttachments            = 1,
>        .maxFragmentCombinedOutputResources       = 8,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180614/e406607c/attachment-0001.sig>