[Mesa-dev] [PATCH] anv: reduce maxFragmentInputComponents

Jason Ekstrand jason at jlekstrand.net
Thu Jun 14 07:48:47 UTC 2018


Makes sense.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Tue, May 29, 2018 at 12:07 AM, Samuel Iglesias Gonsálvez <
siglesias at igalia.com> wrote:

> If the application asks for the maximum number of fragment input
> components (128), use all of them plus some builtins that are
> passed in the VUE, then we exceed the maximum number of used VUE
> slots (32) and we break one assert that checks this limit.
>
> Also, with separate shader objects, we add CLIP_DIST0, CLIP_DIST1
> builtins in brw_compute_vue_map() because we don't know if
> gl_ClipDistance is going to be read/write by an adjacent stage.
>
> Fixes VK-GL-CTS CL#2569.
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> ---
>  src/intel/vulkan/anv_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 374fc16c4c9..87c0d0cb4a6 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -898,7 +898,7 @@ void anv_GetPhysicalDeviceProperties(
>        .maxGeometryOutputComponents              = 128,
>        .maxGeometryOutputVertices                = 256,
>        .maxGeometryTotalOutputComponents         = 1024,
> -      .maxFragmentInputComponents               = 128,
> +      .maxFragmentInputComponents               = 112, /* 128 components
> - (POS, PSIZ, CLIP_DIST0, CLIP_DIST1) */
>        .maxFragmentOutputAttachments             = 8,
>        .maxFragmentDualSrcAttachments            = 1,
>        .maxFragmentCombinedOutputResources       = 8,
> --
> 2.17.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180614/bcbce4da/attachment.html>


More information about the mesa-dev mailing list