[Mesa-dev] [PATCH] radv: Fix flush_bits being used uninitialized.

Samuel Pitoiset samuel.pitoiset at gmail.com
Wed Jun 20 07:54:39 UTC 2018


Ooops, right.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 06/20/2018 12:29 AM, Bas Nieuwenhuizen wrote:
> A case of making things worse while trying to fix something minor ...
> 
> Fixes: ef79457004e "radv: Merge the flush bits of CMASK & DCC clear."
> ---
>   src/amd/vulkan/radv_meta_clear.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c
> index 14af2560821..e9af0532859 100644
> --- a/src/amd/vulkan/radv_meta_clear.c
> +++ b/src/amd/vulkan/radv_meta_clear.c
> @@ -994,7 +994,7 @@ emit_fast_color_clear(struct radv_cmd_buffer *cmd_buffer,
>   	const struct radv_framebuffer *fb = cmd_buffer->state.framebuffer;
>   	const struct radv_image_view *iview = fb->attachments[pass_att].attachment;
>   	VkClearColorValue clear_value = clear_att->clearValue.color;
> -	uint32_t clear_color[2], flush_bits;
> +	uint32_t clear_color[2], flush_bits = 0;
>   	uint32_t cmask_clear_value;
>   	bool ret;
>   
> 


More information about the mesa-dev mailing list