[Mesa-dev] [PATCH] egl: remove redundant initialization

Emil Velikov emil.l.velikov at gmail.com
Fri Mar 2 13:44:52 UTC 2018


On 2 March 2018 at 11:51, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Friday, 2018-03-02 13:28:28 +0200, Andres Gomez wrote:
>> Found by inspection.
>>
>> Cc: Ian Romanick <ian.d.romanick at intel.com>
>> Cc: Emil Velikov <emil.velikov at collabora.com>
>> Cc: Eric Engestrom <eric.engestrom at imgtec.com>
>> Signed-off-by: Andres Gomez <agomez at igalia.com>
>> ---
>>  src/egl/main/eglcontext.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c
>> index 18c1bc59acc..3e5d8ad97bf 100644
>> --- a/src/egl/main/eglcontext.c
>> +++ b/src/egl/main/eglcontext.c
>> @@ -594,7 +594,6 @@ _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, _EGLConfig *conf,
>
> For reviewers: the line removed is a duplicate of the line literally
> just above the context being printed here.
>
Thanks Eric - change did raise an eyebrow on quick skim.
I'd suggest "s/redundant/duplicate/" or picking your note for the
commit message.

Either way
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil


More information about the mesa-dev mailing list