[Mesa-dev] [PATCH] egl: remove redundant initialization

Eric Engestrom eric.engestrom at imgtec.com
Fri Mar 2 11:51:08 UTC 2018


On Friday, 2018-03-02 13:28:28 +0200, Andres Gomez wrote:
> Found by inspection.
> 
> Cc: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Cc: Eric Engestrom <eric.engestrom at imgtec.com>
> Signed-off-by: Andres Gomez <agomez at igalia.com>
> ---
>  src/egl/main/eglcontext.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c
> index 18c1bc59acc..3e5d8ad97bf 100644
> --- a/src/egl/main/eglcontext.c
> +++ b/src/egl/main/eglcontext.c
> @@ -594,7 +594,6 @@ _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, _EGLConfig *conf,

For reviewers: the line removed is a duplicate of the line literally
just above the context being printed here.

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

>     ctx->ClientMajorVersion = 1; /* the default, per EGL spec */
>     ctx->ClientMinorVersion = 0;
>     ctx->Flags = 0;
> -   ctx->Profile = EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR;
>     ctx->ResetNotificationStrategy = EGL_NO_RESET_NOTIFICATION_KHR;
>     ctx->ContextPriority = EGL_CONTEXT_PRIORITY_MEDIUM_IMG;
>     ctx->ReleaseBehavior = EGL_CONTEXT_RELEASE_BEHAVIOR_FLUSH_KHR;
> -- 
> 2.15.1
> 


More information about the mesa-dev mailing list