[Mesa-dev] [PATCH 3/3] meson: make GLX_USE_TLS optional

[Emil Velikov]

On 8 March 2018 at 18:12, Eric Anholt <eric at anholt.net> wrote:
> Greg V <greg at unrelenting.technology> writes:
>
>> FreeBSD builds Mesa with --disable-glx-tls in autotools because:
>> https://github.com/dumbbell/test-tls-initial-exec
>>
>> Add the equivalent option to Meson.
>> ---
>>  meson.build       | 5 ++++-
>>  meson_options.txt | 6 ++++++
>>  2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/meson.build b/meson.build
>> index e71f4ddd73..1c4293d464 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -329,7 +329,10 @@ if with_egl and not (with_platform_drm or with_platform_surfaceless)
>>    endif
>>  endif
>>
>> -pre_args += '-DGLX_USE_TLS'
>> +if get_option('glx-tls')
>> +  pre_args += '-DGLX_USE_TLS'
>> +endif
>
> Instead of introducing an option, could we just test
> host_machine.system() for freebsd here, so that nobody on any OS can
> choose the wrong value?
>
This please. Other platforms also have this problem but it's something
they should sit down and address.

Thanks
Emil