[Mesa-dev] [PATCH 3/3] meson: make GLX_USE_TLS optional

[Dylan Baker]

Quoting Eric Anholt (2018-03-08 10:12:02)
> Greg V <greg at unrelenting.technology> writes:
> 
> > FreeBSD builds Mesa with --disable-glx-tls in autotools because:
> > https://github.com/dumbbell/test-tls-initial-exec
> >
> > Add the equivalent option to Meson.
> > ---
> >  meson.build       | 5 ++++-
> >  meson_options.txt | 6 ++++++
> >  2 files changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index e71f4ddd73..1c4293d464 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -329,7 +329,10 @@ if with_egl and not (with_platform_drm or with_platform_surfaceless)
> >    endif
> >  endif
> >  
> > -pre_args += '-DGLX_USE_TLS'
> > +if get_option('glx-tls')
> > +  pre_args += '-DGLX_USE_TLS'
> > +endif
> 
> Instead of introducing an option, could we just test
> host_machine.system() for freebsd here, so that nobody on any OS can
> choose the wrong value?
> 

I third this, this was always my plan for the meson build if someone needed to
turn off GLX_USE_TLS.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180308/d2d65429/attachment.sig>