[Mesa-dev] [PATCH] intel/blorp: Fix compiler warning about num_layers.

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue Mar 20 14:01:17 UTC 2018


On 16/03/18 22:20, Eric Anholt wrote:
> The compiler doesn't notice that the condition for num_layers to be
> undefined already defined it above (as our assert checked in a debug
> build).
>
> v2: Move the pair of assignments to one outside of the block.
>
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

Thanks!

> ---
>   src/mesa/drivers/dri/i965/brw_blorp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c
> index 72c5d194efec..72578b6ea5cc 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.c
> @@ -1426,8 +1426,8 @@ brw_blorp_clear_depth_stencil(struct brw_context *brw,
>         } else {
>            level = irb->mt_level;
>            start_layer = irb->mt_layer;
> -         num_layers = fb->MaxNumLayers ? irb->layer_count : 1;
>         }
> +      num_layers = fb->MaxNumLayers ? irb->layer_count : 1;
>   
>         stencil_mask = ctx->Stencil.WriteMask[0] & 0xff;
>   




More information about the mesa-dev mailing list