[Mesa-dev] [PATCH 9/9] vbo: Remove now duplicate _DrawVAO notification.

Brian Paul brianp at vmware.com
Tue Mar 20 15:16:37 UTC 2018


On 03/15/2018 11:48 PM, Mathias.Froehlich at gmx.net wrote:
> From: Mathias Fröhlich <mathias.froehlich at web.de>
> 
> The DriverFlags.NewArray bit is set into NewDriverState already on

"The DriverFlags.NewArray bit is already set to NewDriverState in"


> _mesa_set_draw_vao since we have actually just above changed the VAOs
> content. So this can be removed.
> The _vbo_update_inputs is called by the vbo...recalculate_inputs being
> set through the same mechanism as described above.
> 
> Signed-off-by: Mathias Fröhlich <Mathias.Froehlich at web.de>
> ---
>   src/mesa/vbo/vbo_exec_draw.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c
> index 3490dbe44d..026b7be129 100644
> --- a/src/mesa/vbo/vbo_exec_draw.c
> +++ b/src/mesa/vbo/vbo_exec_draw.c
> @@ -232,11 +232,6 @@ vbo_exec_bind_arrays(struct gl_context *ctx)
>             (vao_enabled & ~vao->VertexAttribBufferMask) == 0);
>   
>      _mesa_set_draw_vao(ctx, vao, _vbo_get_vao_filter(mode));
> -   /* The exec VAO is not immutable, so we need to set manually */
> -   ctx->NewDriverState |= ctx->DriverFlags.NewArray;
> -
> -   /* Finally update the inputs array */
> -   _vbo_update_inputs(ctx, &vbo->draw_arrays);
>   }
>   
>   
> 



More information about the mesa-dev mailing list