[Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

Dylan Baker dylan at pnwbakers.com
Tue Mar 20 17:06:10 UTC 2018


Quoting Emil Velikov (2018-03-20 09:29:00)
[snip]
>      gens = []
>      for xml_file in args.xml_files:
> @@ -617,7 +610,7 @@ def main():
>  
>          """))
>  
> -    c("#include \"" + os.path.basename(args.header) + "\"")
> +    c("#include \"" + os.path.basename(header_file) + "\"")

You're calling os.path.basename on a file object, which isn't valid. This should
still be args.header.

>  
>      c(textwrap.dedent("""\
>          #include "brw_context.h"
> -- 
> 2.16.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180320/3f3f3482/attachment.sig>


More information about the mesa-dev mailing list