[Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

[Eero Tamminen]

Hi,

On 20.03.2018 19:06, Dylan Baker wrote:
> Quoting Emil Velikov (2018-03-20 09:29:00)
> [snip]
>>       gens = []
>>       for xml_file in args.xml_files:
>> @@ -617,7 +610,7 @@ def main():
>>   
>>           """))
>>   
>> -    c("#include \"" + os.path.basename(args.header) + "\"")
>> +    c("#include \"" + os.path.basename(header_file) + "\"")
> 
> You're calling os.path.basename on a file object, which isn't valid. This should
> still be args.header.

One could also use <fileobject>.name.


	- Eero

>>   
>>       c(textwrap.dedent("""\
>>           #include "brw_context.h"