[Mesa-dev] [PATCH 2/6] i965/fs: Allow cmod propagation when src0 is a uniform or shader input

Alejandro Piñeiro apinheiro at igalia.com
Thu Mar 22 08:13:29 UTC 2018


Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>


On 22/03/18 01:58, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> No shader-db changes.  This source must have been written by a previous
> instruction, so it cannot be a uniform or a shader input.  However, this
> change allows the next commit to help about 900 more shaders.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/intel/compiler/brw_fs_cmod_propagation.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/compiler/brw_fs_cmod_propagation.cpp b/src/intel/compiler/brw_fs_cmod_propagation.cpp
> index 4625d69..b995a51 100644
> --- a/src/intel/compiler/brw_fs_cmod_propagation.cpp
> +++ b/src/intel/compiler/brw_fs_cmod_propagation.cpp
> @@ -62,7 +62,8 @@ opt_cmod_propagation_local(const gen_device_info *devinfo, bblock_t *block)
>             inst->opcode != BRW_OPCODE_MOV) ||
>            inst->predicate != BRW_PREDICATE_NONE ||
>            !inst->dst.is_null() ||
> -          inst->src[0].file != VGRF ||
> +          (inst->src[0].file != VGRF && inst->src[0].file != ATTR &&
> +           inst->src[0].file != UNIFORM) ||
>            inst->src[0].abs)
>           continue;
>  



More information about the mesa-dev mailing list