[Mesa-dev] [PATCH 2/2] eg/compute: Drop reference on code_bo in destructor.

Nicolai Hähnle nhaehnle at gmail.com
Mon May 7 13:11:25 UTC 2018


Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

On 04.05.2018 08:34, Jan Vesely wrote:
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
>   src/gallium/drivers/r600/evergreen_compute.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c
> index 58626a3114..027930b586 100644
> --- a/src/gallium/drivers/r600/evergreen_compute.c
> +++ b/src/gallium/drivers/r600/evergreen_compute.c
> @@ -462,11 +462,9 @@ static void evergreen_delete_compute_state(struct pipe_context *ctx, void *state
>   	} else {
>   #ifdef HAVE_OPENCL
>   		radeon_shader_binary_clean(&shader->binary);
> +		pipe_resource_reference(&shader->code_bo, NULL);
>   #endif
>   		r600_destroy_shader(&shader->bc);
> -
> -		/* TODO destroy shader->code_bo, shader->const_bo
> -		 * we'll need something like r600_buffer_free */
>   	}
>   	FREE(shader);
>   }
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list