[Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

[Marek Olšák]

On Tue, May 15, 2018 at 3:36 PM, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
wrote:

> On Tue, May 15, 2018 at 9:34 PM, Marek Olšák <maraeo at gmail.com> wrote:
> > On Tue, May 15, 2018 at 3:32 PM, Bas Nieuwenhuizen <
> bas at basnieuwenhuizen.nl>
> > wrote:
> >>
> >> No, this is a vulkan issue, where we want to let apps create linear
> >> RGB float surfaces. (AMDVLK exposes this too:
> >> http://vulkan.gpuinfo.org/displayreport.php?id=3222#formats, see
> >> R32G32B32_SFLOAT and friends) Vulkan has no conecept of staging
> >> textures (or at least the app does not have to tell the driver).
> >>
> >> Though I'm not so sure anymore my patch is the right one, since vulkan
> >> apps can share these surfaces with other apps using the same GPU.
> >
> >
> > Yeah, I think the shareable flag isn't guaranteed to be always set.
>
> It is for radv, the problem in that case was more that we were setting
> shareable but the sharing did not need the extra vega alignment since
> the app is required to use it on the same GPU.
>

You can just skip the vega alignment if bpp is NPOT.

Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180515/ead096ae/attachment.html>