[Mesa-dev] [PATCH] Revert "st/nir: use NIR for asm programs"
eric at anholt.net
Mon May 21 18:15:05 UTC 2018
Timothy Arceri <tarceri at itsqueeze.com> writes:
> On 18/05/18 00:53, Eric Anholt wrote:
>> This reverts commit 5c33e8c7729edd5e16020ebb8703be96523e04f2. It broke
>> fixed function vertex programs on vc4 and v3d, and apparently caused
>> trouble for radeonsi's NIR paths as well.
> Has someone reported trouble with radeonsi NIR? I'm not aware of any
> issues. Dave's patch  was for fixing iris, I had no way to test so
> didn't try send it out myself after you confirmed it fixed your issue.
OK, I had that mistaken.
Still, an unexplained workaround on a branch is not a great response to
this. And even with that workaround plus your change, the following
tests are still broken on V3D:
ati_fragment_shader-render-constants and 6 others.
I'd like to land the revert until there are clean piglit results.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 832 bytes
Desc: not available
More information about the mesa-dev