[Mesa-dev] [PATCH] Revert "st/nir: use NIR for asm programs"

Timothy Arceri tarceri at itsqueeze.com
Mon May 21 23:19:19 UTC 2018

On 22/05/18 04:15, Eric Anholt wrote:
> Timothy Arceri <tarceri at itsqueeze.com> writes:
>> On 18/05/18 00:53, Eric Anholt wrote:
>>> This reverts commit 5c33e8c7729edd5e16020ebb8703be96523e04f2.  It broke
>>> fixed function vertex programs on vc4 and v3d, and apparently caused
>>> trouble for radeonsi's NIR paths as well.
>> Has someone reported trouble with radeonsi NIR? I'm not aware of any
>> issues. Dave's patch [1] was for fixing iris, I had no way to test so
>> didn't try send it out myself after you confirmed it fixed your issue.
> OK, I had that mistaken.
> Still, an unexplained workaround on a branch is not a great response to
> this.  And even with that workaround plus your change, the following
> tests are still broken on V3D:
> gl-1.0-rendermode-fallback
> opengl-1.1/gl_select-*
> fp-arb-fragment-coord-conventions-integer.shader_test
> vp-max-array
> ati_fragment_shader-render-constants and 6 others.
> I'd like to land the revert until there are clean piglit results.

Sure. As I said I have no idea why the workaround helps, seems radeonsi 
does something different to the other drivers. For now feel free to push 
the revert.

Acked-by: Timothy Arceri <tarceri at itsqueeze.com>


More information about the mesa-dev mailing list