[Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

[Robert Foss]

Hey,

On 2018-05-25 02:17, Rob Herring wrote:
> On Thu, May 24, 2018 at 6:23 AM, Robert Foss <robert.foss at collabora.com> wrote:
>> Hey,
>>
>> I don't think I've received any feedback on this version yet.
>> If anyone has some time to spare, it would be nice to get it merged.
>>
>> Just to be clear about the libdrm branch linked in the cover letter,
>> it is not required. Only for virgl platforms which happens to be what
>> I tested on.
> 
> virgl will still fallback to using the first render node without those
> libdrm changes, right? If not, I don't think we should apply until
> we're not breaking a platform...

No it will not fall back. I agree that holding off makes more sense.

Emil Velikov had some objections to the approach in the libdrm branch,
and started a new branch from scratch with the same goals. It isn't
yet fully functional, but I'm working with him to have it sent out
as soon as possible.


Rob.

> 
> Rob
> 
>>
>> Rob.
>>
>> On 2018-05-11 15:47, Robert Foss wrote:
>>>
>>> This series replaces the dependency on
>>> GRALLOC_MODULE_PERFORM_GET_DRM_FD with DRM node
>>> probing and disables the support for drm_gralloc.
>>>
>>> The series has been tested on Qemu+AOSP, where a
>>> virtio gpu was successfully probed for and
>>> opened.
>>>
>>> This however required adding support in libdrm
>>> for virtio gpus, and virtio buses. An initial
>>> patch for this can be found here:
>>>
>>> https://gitlab.collabora.com/robertfoss/libdrm/tree/virtio_rfc
>>>
>>> Changes since v1:
>>>    - Added fix for build issue
>>>    - Do not rely on libdrm for probing
>>>    - Distinguish between errors and when no drm devices are found
>>>
>>> Changes since RFC:
>>>    - Rebased work on the libdrm patch [2].
>>>    - Included patch from Rob Herring disabling drm_gralloc/flink
>>>      support by default.
>>>    - Added device handler driver probing.
>>>
>>>
>>> Rob Herring (1):
>>>     egl/android: #ifdef out flink name support
>>>
>>> Robert Foss (2):
>>>     gallium/util: Fix build error due to cast to different size
>>>     egl/android: Add DRM node probing and filtering
>>>
>>>    src/egl/Android.mk                            |   6 +-
>>>    src/egl/drivers/dri2/egl_dri2.h               |   2 -
>>>    src/egl/drivers/dri2/platform_android.c       | 206 ++++++++++++++----
>>>    .../auxiliary/util/u_debug_stack_android.cpp  |   4 +-
>>>    4 files changed, 174 insertions(+), 44 deletions(-)
>>>
>>