[Mesa-dev] [PATCH] nir: add unsigned less then comparison simplification

[Timothy Arceri]

On 01/06/18 02:40, Ian Romanick wrote:
> On 05/30/2018 07:09 PM, Timothy Arceri wrote:
>> On 31/05/18 11:33, Ian Romanick wrote:
>>> "less than"
>>
>> whoops ... luckly I removed that bit from the description before pushing
>>
>>>
>>> This regression is with  "nir: implement the GLSL equivalent of if
>>> simplication in nir_opt_if"?  I'll check to see if this helps the issues
>>> that I'm seeing with that patch...
>>
>> Correct.
> 
> Dang.  It doesn't help the Plane Shift shaders that are regressed. :(

Can you grab a dump of one of the shaders for me?


> 
>>> On 05/30/2018 04:09 AM, Timothy Arceri wrote:
>>>> This avoids loop unrolling regressions in Wolfenstein II on DXVK
>>>> with an upcoming optimisation series from Samuel.
>>>> ---
>>>>    src/compiler/nir/nir_opt_algebraic.py | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/src/compiler/nir/nir_opt_algebraic.py
>>>> b/src/compiler/nir/nir_opt_algebraic.py
>>>> index 909ea3daf42..14ffd9e7b82 100644
>>>> --- a/src/compiler/nir/nir_opt_algebraic.py
>>>> +++ b/src/compiler/nir/nir_opt_algebraic.py
>>>> @@ -149,6 +149,7 @@ optimizations = [
>>>>       (('~inot', ('feq', a, b)), ('fne', a, b)),
>>>>       (('~inot', ('fne', a, b)), ('feq', a, b)),
>>>>       (('inot', ('ilt', a, b)), ('ige', a, b)),
>>>> +   (('inot', ('ult', a, b)), ('uge', a, b)),
>>>>       (('inot', ('ige', a, b)), ('ilt', a, b)),
>>>>       (('inot', ('ieq', a, b)), ('ine', a, b)),
>>>>       (('inot', ('ine', a, b)), ('ieq', a, b)),
>