[Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

Michel Dänzer michel at daenzer.net
Thu Nov 1 15:16:30 UTC 2018


Hi Mathias,


On 2018-11-01 8:40 a.m., Mathias.Froehlich at gmx.net wrote:
> From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
> 
> Hi Emil,
> 
> There seems to be a failure with the latest patches you pushed.
> The patch fixes a failure with the sort order in egl symbols.

Well, now it's broken with other locales. :)

I guess src/egl/egl-entrypoint-check itself should make sure sort runs
with locale settings resulting in the expected order.


> FYI, I observed that the latest series that you sent for review
> differs a lot in the individual patches. Kind of looks like a
> problem that may have slipped in during a rebase -i session.
> The total diff past the complete series only differs by this
> current change that introduces the failure.

BTW, this kind of commentary should be after the --- line, otherwise
it's considered part of the commit log by Git tools.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the mesa-dev mailing list