[Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

Mathias Fröhlich Mathias.Froehlich at gmx.net
Thu Nov 1 15:56:50 UTC 2018


Hi Michel,

> > There seems to be a failure with the latest patches you pushed.
> > The patch fixes a failure with the sort order in egl symbols.
> 
> Well, now it's broken with other locales. :)
> 
> I guess src/egl/egl-entrypoint-check itself should make sure sort runs
> with locale settings resulting in the expected order.

I was just about to send something, when Eric sent something.

Out of curiosity, which locale does invert the capitals with respect
to ascii number ordering?

Do I also remember right that the reson for sorting was a binary
search being done on the names for getprocaddress or something?
So, the ascii table sorting matters, right?

> BTW, this kind of commentary should be after the --- line, otherwise
> it's considered part of the commit log by Git tools.

Ok, thanks!
Well I should have mentioned, that I usually check if git just rebases fine on a
branch when it is pushed. And that sent series did not get just eaten up by
the pushed variant on rebase.

best

Mathias




More information about the mesa-dev mailing list