[Mesa-dev] [PATCH 1/2] glsl: Add warning tests for identifiers with __

[Matt Turner]

On Thu, Nov 1, 2018 at 3:37 PM Ian Romanick <idr at freedesktop.org> wrote:
>
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Matt Turner <mattst88 at gmail.com>
> ---
>  .../tests/warnings/031-__-in-function-name.vert    | 22 ++++++++++++++++++++++
>  .../warnings/031-__-in-function-name.vert.expected |  3 +++
>  2 files changed, 25 insertions(+)
>  create mode 100644 src/compiler/glsl/tests/warnings/031-__-in-function-name.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/031-__-in-function-name.vert.expected
>
> diff --git a/src/compiler/glsl/tests/warnings/031-__-in-function-name.vert b/src/compiler/glsl/tests/warnings/031-__-in-function-name.vert
> new file mode 100644
> index 00000000000..84d643d4509
> --- /dev/null
> +++ b/src/compiler/glsl/tests/warnings/031-__-in-function-name.vert
> @@ -0,0 +1,22 @@
> +#version 130
> +
> +float __foo(float x)
> +{
> +   return 6.0 * x;
> +}
> +
> +float __bar(float x)
> +{
> +   return 3.0 * x;
> +}
> +
> +float __blat(float x)
> +{
> +   return 2.0 * x;
> +}

Might be nice to test different types of identifiers -- functions,
variables, parameters, etc. I don't feel strongly.

Reviewed-by: Matt Turner <mattst88 at gmail.com>